<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126129/">https://git.reviewboard.kde.org/r/126129/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 21st, 2015, 11:34 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This looks interesting. Could you provide some screenshots to evaluate the feature?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">http://i.imgur.com/dnLlbVC.png
http://i.imgur.com/xmNsiNh.png
http://i.imgur.com/PzCsiQ9.png
http://i.imgur.com/TSrf4XI.png</pre>
<br />
<p>- Sergii</p>
<br />
<p>On November 21st, 2015, 6:44 p.m. UTC, Sergii Pylypenko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect, Albert Vaca Cintora and Aleix Pol Gonzalez.</div>
<div>By Sergii Pylypenko.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2015, 6:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-android
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've noticed a lamentable absence of the media controls in Android notification area in KDEConnect, which any other music player provides, so I've added this feature, and only then I've noticed the noti-mediacontrol branch.
So here's my patch, for reference if nothing more.
The only improvement over the noti-mediacontrol branch it has is that this patch actually compiles. Other than that it's pretty basic - there are buttons Play/Pause, Previos, Next, and the KDEConnect icon to open the multimedia control dialog. It also displays the song name.
Notification can be enabled or disabled by a checkbox in the multimedia control dialog. The notification will not be created until you open this dialog, but it will stay persistent when you close the app, until you open the multimedia control dialog and disable the checkbox.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Launched KDEConnect on a phone with Android 5.0, clicked all 4 buttons in the notification, clicked checkbox in the multimedia control dialog, watched the song name changing in the notification, everything seemed to work well until my KDE installation bugged out and corrupted all windows (but Plasma did not crash).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>AndroidManifest.xml <span style="color: grey">(c16b068)</span></li>
<li>res/layout/mpris_control.xml <span style="color: grey">(daba05a)</span></li>
<li>res/layout/mpris_control_notification.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>res/values/strings.xml <span style="color: grey">(6281674)</span></li>
<li>res/xml/mprisplugin_preferences.xml <span style="color: grey">(c565a35)</span></li>
<li>src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java <span style="color: grey">(371c2af)</span></li>
<li>src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisNotification.java <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126129/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>