Review Request 123145: Add support for sending and receiving payloads. (Android)

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123145/#review78092
-----------------------------------------------------------



src/org/kde/kdeconnect/Backends/BluetoothBackend/BluetoothLink.java (line 93)
<https://git.reviewboard.kde.org/r/123145/#comment53509>

    What's the point of the markers?



src/org/kde/kdeconnect/Backends/BluetoothBackend/BluetoothLink.java (line 116)
<https://git.reviewboard.kde.org/r/123145/#comment53508>

    We don't always know the payload size, and in those cases the size is 0 (or -1, I don't remember). This won't work in those cases.



src/org/kde/kdeconnect/Backends/BluetoothBackend/BluetoothLink.java (line 136)
<https://git.reviewboard.kde.org/r/123145/#comment53507>

    else break, or this can be an infinite loop


- Albert Vaca Cintora


On mar. 26, 2015, 7:22 p.m., Saikrishna Arcot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123145/
> -----------------------------------------------------------
> 
> (Updated mar. 26, 2015, 7:22 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> See /r/123094 for details.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Backends/BluetoothBackend/BluetoothLink.java 16969a2c0c59ead125e202522802fe4ab9463b12 
> 
> Diff: https://git.reviewboard.kde.org/r/123145/diff/
> 
> 
> Testing
> -------
> 
> See /r/123094 for details.
> 
> 
> Thanks,
> 
> Saikrishna Arcot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150327/d47b53e6/attachment-0001.html>