Review Request 123076: Remove KNotifications dependency from libkdeconnectcore

Aleix Pol Gonzalez aleixpol at kde.org
Sat Mar 21 00:55:06 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123076/
-----------------------------------------------------------

(Updated March 21, 2015, 1:55 a.m.)


Review request for kdeconnect.


Changes
-------

Add all the find_package! \o/


Repository: kdeconnect-kde


Description
-------

Moves the implementation into the actual daemon. This opens the possibility for different ways to expose these notifications depending on where the libkdeconnect will be deployed.


Diffs (updated)
-----

  CMakeLists.txt 05a1b2c 
  core/CMakeLists.txt 2026317 
  core/daemon.h 1817bdf 
  core/daemon.cpp 4e9cec4 
  core/device.cpp 96c62b5 
  core/kdeconnectconfig.cpp 1356f43 
  daemon/CMakeLists.txt 8847c32 
  daemon/kdeconnectd.cpp cb7de79 
  plugins/battery/CMakeLists.txt f6a6c5b 
  plugins/notifications/CMakeLists.txt 565bf7f 
  plugins/ping/CMakeLists.txt 15daa70 
  plugins/screensaver-inhibit/CMakeLists.txt 8936930 
  plugins/sftp/CMakeLists.txt cecedf8 
  plugins/share/CMakeLists.txt fed160c 
  plugins/telephony/CMakeLists.txt 9ec3027 

Diff: https://git.reviewboard.kde.org/r/123076/diff/


Testing
-------

I unpaired myself and paired back.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150321/cfa199e5/attachment-0001.html>


More information about the KDEConnect mailing list