Review Request 123076: Remove KNotifications dependency from libkdeconnectcore

[Aleix Pol Gonzalez]

> On March 20, 2015, 9 p.m., Ashish Bansal wrote:
> > core/CMakeLists.txt, line 13
> > <https://git.reviewboard.kde.org/r/123076/diff/1/?file=355838#file355838line13>
> >
> >     We can remove this now.
> 
> Aleix Pol Gonzalez wrote:
>     No, we cannot. Notifications are used by many plugins.
> 
> Albert Vaca Cintora wrote:
>     It should be moved to the plugins then. Right now it's in core and as Ashish pointed out we don't need it anymore to build the core.

It's also required by the daemon, and as of today it's not possible to use kdeconnect without it. Let's move things when we know where they should go.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123076/#review77851
-----------------------------------------------------------


On March 20, 2015, 1:28 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123076/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 1:28 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Moves the implementation into the actual daemon. This opens the possibility for different ways to expose these notifications depending on where the libkdeconnect will be deployed.
> 
> 
> Diffs
> -----
> 
>   core/CMakeLists.txt 2026317 
>   core/daemon.h 1817bdf 
>   core/daemon.cpp 4e9cec4 
>   core/device.h c2d743a 
>   core/device.cpp 96c62b5 
>   core/kdeconnectconfig.cpp 1356f43 
>   daemon/CMakeLists.txt 8847c32 
>   daemon/kdeconnectd.cpp cb7de79 
> 
> Diff: https://git.reviewboard.kde.org/r/123076/diff/
> 
> 
> Testing
> -------
> 
> I unpaired myself and paired back.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150320/2f91b306/attachment.html>