Review Request 122927: Added a baseclass for the plugins' KCMs and a class for the plugins' config

[Albert Vaca Cintora]

> On mar. 14, 2015, 5:22 a.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 17
> > <https://git.reviewboard.kde.org/r/122927/diff/2/?file=354847#file354847line17>
> >
> >     ? XD

Intentional change.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122927/#review77451
-----------------------------------------------------------


On mar. 14, 2015, 5:22 a.m., Albert Vaca Cintora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122927/
> -----------------------------------------------------------
> 
> (Updated mar. 14, 2015, 5:22 a.m.)
> 
> 
> Review request for kdeconnect and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Centralizing the plugins' config will ensure that all the plugins store it
> the same way (ie: not in random files scattered around, like until now).
> The base KCM class, together with the already existing base plugin class,
> will give easy access to all the plugins to this centralized config. Also,
> now the settings are not shared across devices (that is: every device can
> have different config for a same plugin).
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 32cda38709ffebfa08c477b83b85014ba905fc54 
>   cli/CMakeLists.txt 8a8f40b513217104fc49100758126945a26b7387 
>   cli/kdeconnect-cli.cpp 70a894e1becc306e9c482dad33e9b1b89f253390 
>   core/CMakeLists.txt 95b8bd84fb995ccf9dda3f953378beac8cd285ed 
>   core/backends/devicelink.h af1fe1251f151c95f190c9193de7c099a6b743a5 
>   core/backends/linkprovider.h 00805c1b5b890011e4ae043add387318cc367c03 
>   core/kdeconnectconfig.h d1e721a1e3d4851a8a5b769654e6cc69af9fd6d1 
>   core/kdeconnectconfig.cpp b165f4dbbf082b709bc51a05becc7d799c48e44e 
>   core/kdeconnectplugin.h 564786c296a2643d5e9d1b0c131aa5276668bea2 
>   core/kdeconnectplugin.cpp e7f72c60b032843af296de6fcdc0edb70d8ad593 
>   core/kdeconnectpluginconfig.h PRE-CREATION 
>   core/kdeconnectpluginconfig.cpp PRE-CREATION 
>   core/pluginloader.cpp 37bd4baacc08d56f036cd7c74c4b65fb4ab3a97e 
>   daemon/CMakeLists.txt f593d0e9771524794da5c4bed2ee6f613e80a79d 
>   daemon/kdeconnectd.cpp 40a53e5bd4029ae173725697830304052669df7c 
>   kcm/CMakeLists.txt 03796a06ab377a0b997badc81abc0bc250ff0297 
>   kcm/kcm.cpp 8c377fa8c3ec54010c8d50880ca0e1dbb96bbeb0 
>   kcmplugin/CMakeLists.txt PRE-CREATION 
>   kcmplugin/kdeconnectpluginkcm.cpp PRE-CREATION 
>   plugins/pausemusic/CMakeLists.txt 44d0902f6a9bc229cdb5b06352e8388bfb24f58d 
>   plugins/pausemusic/pausemusic_config.h 075e2958d7f0198c9402456c81f02fc11f5999e3 
>   plugins/pausemusic/pausemusic_config.cpp 03dacf9ab79b1f1ef3d0c12adf675e710de94821 
>   plugins/pausemusic/pausemusicplugin.cpp a9cdc681183e372f3ff029a263024f3e99468385 
>   plugins/ping/pingplugin.cpp 72c2a50da2bd60fb42674ef7253944e62537934b 
>   plugins/sftp/CMakeLists.txt 384d70f69db0ae1490353603a3065fdcae7515d8 
>   plugins/sftp/kdeconnect_sftp_config.desktop 746593fcd0159c42de88fc9524669f9da6c5a1bc 
>   plugins/sftp/mounter.h 91b6bade606a7d5178a77a9c3b478d156c0bdb61 
>   plugins/sftp/mounter.cpp 70dcd19d556980d69bb28a887df90c9c766d9c04 
>   plugins/sftp/sftp_config.h 5ed9b269eaf7a35c3c86c3c12310589d44383fcc 
>   plugins/sftp/sftp_config.cpp 31a068990a2671e26870befc2ba08638fecd10b8 
>   plugins/sftp/sftp_config.ui 30e1c797e7448b361fc38a8ede9017c8328ebc34 
>   plugins/sftp/sftpplugin.h afd651e53bcdd1aa81fe4a3c0eec3f3f51e1021c 
>   plugins/sftp/sftpplugin.cpp e98b087dc1452440349b7d266fe8426b8e353d49 
>   plugins/share/CMakeLists.txt 4783864902773106afa40f7d7b55706a879bab27 
>   plugins/share/share_config.h 7743fcc9c1f0f8d162a66dfbc048cdd71610b826 
>   plugins/share/share_config.cpp 397547ac15e2cc1578359b7e0dee0bbf1abeb429 
>   plugins/share/shareplugin.cpp 2c1566bd11a080dd711e01b75cd5d93bc722ee44 
>   plugins/telephony/telephonyplugin.h fb57d5ebdfa74fb9c8fa7ed92e865a438c5cf156 
>   tests/CMakeLists.txt 4c508b74baa04098eb1bc6be1a29abe9d471c7f7 
> 
> Diff: https://git.reviewboard.kde.org/r/122927/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Vaca Cintora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150314/e8a3945b/attachment.html>