<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122927/">https://git.reviewboard.kde.org/r/122927/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On març 14th, 2015, 5:22 a.m. CET, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/122927/diff/2/?file=354847#file354847line17" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">17</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">include_directories</span><span class="p">(</span><span class="o">${</span><span class="nv">CMAKE_SOURCE_DIR</span><span class="o">}</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">? XD</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Intentional change.</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On març 14th, 2015, 5:22 a.m. CET, Albert Vaca Cintora wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect and Aleix Pol Gonzalez.</div>
<div>By Albert Vaca Cintora.</div>
<p style="color: grey;"><i>Updated mar. 14, 2015, 5:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Centralizing the plugins' config will ensure that all the plugins store it
the same way (ie: not in random files scattered around, like until now).
The base KCM class, together with the already existing base plugin class,
will give easy access to all the plugins to this centralized config. Also,
now the settings are not shared across devices (that is: every device can
have different config for a same plugin).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(32cda38709ffebfa08c477b83b85014ba905fc54)</span></li>
<li>cli/CMakeLists.txt <span style="color: grey">(8a8f40b513217104fc49100758126945a26b7387)</span></li>
<li>cli/kdeconnect-cli.cpp <span style="color: grey">(70a894e1becc306e9c482dad33e9b1b89f253390)</span></li>
<li>core/CMakeLists.txt <span style="color: grey">(95b8bd84fb995ccf9dda3f953378beac8cd285ed)</span></li>
<li>core/backends/devicelink.h <span style="color: grey">(af1fe1251f151c95f190c9193de7c099a6b743a5)</span></li>
<li>core/backends/linkprovider.h <span style="color: grey">(00805c1b5b890011e4ae043add387318cc367c03)</span></li>
<li>core/kdeconnectconfig.h <span style="color: grey">(d1e721a1e3d4851a8a5b769654e6cc69af9fd6d1)</span></li>
<li>core/kdeconnectconfig.cpp <span style="color: grey">(b165f4dbbf082b709bc51a05becc7d799c48e44e)</span></li>
<li>core/kdeconnectplugin.h <span style="color: grey">(564786c296a2643d5e9d1b0c131aa5276668bea2)</span></li>
<li>core/kdeconnectplugin.cpp <span style="color: grey">(e7f72c60b032843af296de6fcdc0edb70d8ad593)</span></li>
<li>core/kdeconnectpluginconfig.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/kdeconnectpluginconfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/pluginloader.cpp <span style="color: grey">(37bd4baacc08d56f036cd7c74c4b65fb4ab3a97e)</span></li>
<li>daemon/CMakeLists.txt <span style="color: grey">(f593d0e9771524794da5c4bed2ee6f613e80a79d)</span></li>
<li>daemon/kdeconnectd.cpp <span style="color: grey">(40a53e5bd4029ae173725697830304052669df7c)</span></li>
<li>kcm/CMakeLists.txt <span style="color: grey">(03796a06ab377a0b997badc81abc0bc250ff0297)</span></li>
<li>kcm/kcm.cpp <span style="color: grey">(8c377fa8c3ec54010c8d50880ca0e1dbb96bbeb0)</span></li>
<li>kcmplugin/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcmplugin/kdeconnectpluginkcm.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/pausemusic/CMakeLists.txt <span style="color: grey">(44d0902f6a9bc229cdb5b06352e8388bfb24f58d)</span></li>
<li>plugins/pausemusic/pausemusic_config.h <span style="color: grey">(075e2958d7f0198c9402456c81f02fc11f5999e3)</span></li>
<li>plugins/pausemusic/pausemusic_config.cpp <span style="color: grey">(03dacf9ab79b1f1ef3d0c12adf675e710de94821)</span></li>
<li>plugins/pausemusic/pausemusicplugin.cpp <span style="color: grey">(a9cdc681183e372f3ff029a263024f3e99468385)</span></li>
<li>plugins/ping/pingplugin.cpp <span style="color: grey">(72c2a50da2bd60fb42674ef7253944e62537934b)</span></li>
<li>plugins/sftp/CMakeLists.txt <span style="color: grey">(384d70f69db0ae1490353603a3065fdcae7515d8)</span></li>
<li>plugins/sftp/kdeconnect_sftp_config.desktop <span style="color: grey">(746593fcd0159c42de88fc9524669f9da6c5a1bc)</span></li>
<li>plugins/sftp/mounter.h <span style="color: grey">(91b6bade606a7d5178a77a9c3b478d156c0bdb61)</span></li>
<li>plugins/sftp/mounter.cpp <span style="color: grey">(70dcd19d556980d69bb28a887df90c9c766d9c04)</span></li>
<li>plugins/sftp/sftp_config.h <span style="color: grey">(5ed9b269eaf7a35c3c86c3c12310589d44383fcc)</span></li>
<li>plugins/sftp/sftp_config.cpp <span style="color: grey">(31a068990a2671e26870befc2ba08638fecd10b8)</span></li>
<li>plugins/sftp/sftp_config.ui <span style="color: grey">(30e1c797e7448b361fc38a8ede9017c8328ebc34)</span></li>
<li>plugins/sftp/sftpplugin.h <span style="color: grey">(afd651e53bcdd1aa81fe4a3c0eec3f3f51e1021c)</span></li>
<li>plugins/sftp/sftpplugin.cpp <span style="color: grey">(e98b087dc1452440349b7d266fe8426b8e353d49)</span></li>
<li>plugins/share/CMakeLists.txt <span style="color: grey">(4783864902773106afa40f7d7b55706a879bab27)</span></li>
<li>plugins/share/share_config.h <span style="color: grey">(7743fcc9c1f0f8d162a66dfbc048cdd71610b826)</span></li>
<li>plugins/share/share_config.cpp <span style="color: grey">(397547ac15e2cc1578359b7e0dee0bbf1abeb429)</span></li>
<li>plugins/share/shareplugin.cpp <span style="color: grey">(2c1566bd11a080dd711e01b75cd5d93bc722ee44)</span></li>
<li>plugins/telephony/telephonyplugin.h <span style="color: grey">(fb57d5ebdfa74fb9c8fa7ed92e865a438c5cf156)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(4c508b74baa04098eb1bc6be1a29abe9d471c7f7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122927/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>