Review Request 122744: Simplify initialization of the private key

Albert Vaca Cintora albertvaka at gmail.com
Sun Mar 1 23:28:01 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122744/#review76851
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Vaca Cintora


On mar. 2, 2015, 12:25 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122744/
> -----------------------------------------------------------
> 
> (Updated mar. 2, 2015, 12:25 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> First I saw it wasn't being found, I started digging, I solved this and a couple of other issues as well.
> - Only 1 private key on the whole system, instead of one per service.
> - Path specified only once rather than in daemon.cpp and device.cpp.
> 
> 
> Diffs
> -----
> 
>   core/daemon.cpp 3688b4b 
>   core/device.h 2ebb403 
>   core/device.cpp e8412b7 
> 
> Diff: https://git.reviewboard.kde.org/r/122744/diff/
> 
> 
> Testing
> -------
> 
> Now it doesn't keep crashing and getting restarted anymore.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150301/57d71d6f/attachment-0001.html>


More information about the KDEConnect mailing list