Review Request 122744: Simplify initialization of the private key

Aleix Pol Gonzalez aleixpol at kde.org
Sun Mar 1 23:25:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122744/
-----------------------------------------------------------

(Updated March 2, 2015, 12:25 a.m.)


Review request for kdeconnect and Albert Vaca Cintora.


Changes
-------

Removed all presence of the privateKeyPath in the config files.


Repository: kdeconnect-kde


Description
-------

First I saw it wasn't being found, I started digging, I solved this and a couple of other issues as well.
- Only 1 private key on the whole system, instead of one per service.
- Path specified only once rather than in daemon.cpp and device.cpp.


Diffs (updated)
-----

  core/daemon.cpp 3688b4b 
  core/device.h 2ebb403 
  core/device.cpp e8412b7 

Diff: https://git.reviewboard.kde.org/r/122744/diff/


Testing
-------

Now it doesn't keep crashing and getting restarted anymore.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150301/f1f70140/attachment.html>


More information about the KDEConnect mailing list