Review Request 124166: Drop NetworkPackage QObject heritage
Aleix Pol Gonzalez
aleixpol at kde.org
Wed Jun 24 18:59:20 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124166/
-----------------------------------------------------------
(Updated June 24, 2015, 6:59 p.m.)
Status
------
This change has been marked as submitted.
Review request for kdeconnect.
Changes
-------
Submitted with commit 1a2f569a4797c325e18b2f2fecd2bfa6d854707e by Aleix Pol to branch master.
Repository: kdeconnect-kde
Description
-------
It was only used for introspection and we can use Q_GADGET for that.
Make the NetworkPackage objects much lighter.
Diffs
-----
core/networkpackage.h 6a0bf9c
core/networkpackage.cpp 64cfab7
Diff: https://git.reviewboard.kde.org/r/124166/diff/
Testing
-------
Re-compiled, tests still pass, using it without noticeable regressions.
Thanks,
Aleix Pol Gonzalez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150624/b84f694d/attachment.html>
More information about the KDEConnect
mailing list