Review Request 124166: Drop NetworkPackage QObject heritage

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124166/#review81725
-----------------------------------------------------------

Ship it!


Awe-some!

- Albert Vaca Cintora


On June 24, 2015, 9:59 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124166/
> -----------------------------------------------------------
> 
> (Updated June 24, 2015, 9:59 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> It was only used for introspection and we can use Q_GADGET for that.
> 
> Make the NetworkPackage objects much lighter.
> 
> 
> Diffs
> -----
> 
>   core/networkpackage.h 6a0bf9c 
>   core/networkpackage.cpp 64cfab7 
> 
> Diff: https://git.reviewboard.kde.org/r/124166/diff/
> 
> 
> Testing
> -------
> 
> Re-compiled, tests still pass, using it without noticeable regressions.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150624/e93b148e/attachment.html>