Review Request 124100: Implement an MPRIS client plugin

[Albert Vaca Cintora]

> On June 15, 2015, 8:34 p.m., Albert Vaca Cintora wrote:
> > plugins/CMakeLists.txt, line 8
> > <https://git.reviewboard.kde.org/r/124100/diff/3/?file=379936#file379936line8>
> >
> >     Can you add a condition so we only compile this if we are compiling the app? Otherwise, it's a useless plugin.
> 
> Aleix Pol Gonzalez wrote:
>     Maybe we could make (some) plugins load on demand.

I don't think it's worth the effort right now. For this case, eventually we will have some media controls embedded in the Plasmoid and then we will enable it for the desktop as well.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124100/#review81502
-----------------------------------------------------------


On June 15, 2015, 12:02 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124100/
> -----------------------------------------------------------
> 
> (Updated June 15, 2015, 12:02 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Makes it possible to control remote MPRIS instances.
> 
> 
> Diffs
> -----
> 
>   app/qml/main.qml 43a0d6d 
>   app/qml/mpris.qml PRE-CREATION 
>   app/resources.qrc 0e02918 
>   core/networkpackage.h a79ac4a 
>   interfaces/CMakeLists.txt 7879b35 
>   interfaces/dbusinterfaces.h 142da39 
>   interfaces/dbusinterfaces.cpp 6ee93bd 
>   plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp 76a7601 
>   plugins/CMakeLists.txt 083c087 
>   plugins/mpriscontrol/mpriscontrolplugin.cpp a33cbdc 
>   plugins/mprisremote/CMakeLists.txt PRE-CREATION 
>   plugins/mprisremote/kdeconnect_mprisremote.json PRE-CREATION 
>   plugins/mprisremote/mprisremoteplugin.h PRE-CREATION 
>   plugins/mprisremote/mprisremoteplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124100/diff/
> 
> 
> Testing
> -------
> 
> Yes, all seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150616/01deb9a8/attachment-0001.html>