Review Request 124100: Implement an MPRIS client plugin

[Aleix Pol Gonzalez]

> On June 16, 2015, 5:34 a.m., Albert Vaca Cintora wrote:
> > plugins/CMakeLists.txt, line 8
> > <https://git.reviewboard.kde.org/r/124100/diff/3/?file=379936#file379936line8>
> >
> >     Can you add a condition so we only compile this if we are compiling the app? Otherwise, it's a useless plugin.

Maybe we could make (some) plugins load on demand.


> On June 16, 2015, 5:34 a.m., Albert Vaca Cintora wrote:
> > interfaces/dbusinterfaces.h, line 105
> > <https://git.reviewboard.kde.org/r/124100/diff/3/?file=379933#file379933line105>
> >
> >     Can you add a TODO line here with what we should change once the problem in Qt is fixed? Otherwise this is not future-actionable by somebody without knowledge about the issue (like me :).

True, will do.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124100/#review81502
-----------------------------------------------------------


On June 15, 2015, 9:02 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124100/
> -----------------------------------------------------------
> 
> (Updated June 15, 2015, 9:02 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Makes it possible to control remote MPRIS instances.
> 
> 
> Diffs
> -----
> 
>   app/qml/main.qml 43a0d6d 
>   app/qml/mpris.qml PRE-CREATION 
>   app/resources.qrc 0e02918 
>   core/networkpackage.h a79ac4a 
>   interfaces/CMakeLists.txt 7879b35 
>   interfaces/dbusinterfaces.h 142da39 
>   interfaces/dbusinterfaces.cpp 6ee93bd 
>   plasmoid/declarativeplugin/kdeconnectdeclarativeplugin.cpp 76a7601 
>   plugins/CMakeLists.txt 083c087 
>   plugins/mpriscontrol/mpriscontrolplugin.cpp a33cbdc 
>   plugins/mprisremote/CMakeLists.txt PRE-CREATION 
>   plugins/mprisremote/kdeconnect_mprisremote.json PRE-CREATION 
>   plugins/mprisremote/mprisremoteplugin.h PRE-CREATION 
>   plugins/mprisremote/mprisremoteplugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124100/diff/
> 
> 
> Testing
> -------
> 
> Yes, all seems to work.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150616/992f1868/attachment.html>