Review Request 124044: Changed project structure to incorporate tests and added network package and device test

Vineet Garg grg.vineet at gmail.com
Tue Jun 9 19:33:29 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124044/
-----------------------------------------------------------

(Updated June 9, 2015, 7:33 p.m.)


Review request for kdeconnect and Albert Vaca Cintora.


Changes
-------

Now using mocked LanLink and LanLinkProvider in DeviceTest


Repository: kdeconnect-android


Description
-------

* Changed project structure to incorporate tests.
* Directory 'src' has 3 sub-directories main(contains main app source), androidTest(contains source for tests that needs to be run on Android device, test(contains source for tests that can be run on local JVM, currently empty).
* Written NetworkPackageTest based on NetworkPackageTest of kdeconnect-kde.
* Written a basic DeviceTest, that tests functionality for Device class.


Diffs (updated)
-----

  build.gradle fd4dabe 
  src/org/kde/kdeconnect/Device.java a8a25c7 
  src/org/kde/kdeconnect/NetworkPackage.java e5a777e 
  tests/org/kde/kdeconnect/DeviceTest.java PRE-CREATION 
  tests/org/kde/kdeconnect/NetworkPackageTest.java PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124044/diff/


Testing
-------

Application builds properly
Tests run successfully


Thanks,

Vineet Garg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150609/0425123e/attachment-0001.html>


More information about the KDEConnect mailing list