Review Request 124044: Changed project structure to incorporate tests and added network package and device test

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124044/#review81343
-----------------------------------------------------------

Ship it!


Looks good, but I saw in your previous diff you added Mockito and it's not here anymore. I would add it back, we probably will use it. See below a good place where you could already use it:


tests/org/kde/kdeconnect/DeviceTest.java (line 117)
<https://git.reviewboard.kde.org/r/124044/#comment55735>

    No need to instantiate a real LanLinkProvider, this seems like a perfect use case for Mockito.mock(LinkProvider.class).


- Albert Vaca Cintora


On June 9, 2015, 2:01 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124044/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 2:01 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> * Changed project structure to incorporate tests.
> * Directory 'src' has 3 sub-directories main(contains main app source), androidTest(contains source for tests that needs to be run on Android device, test(contains source for tests that can be run on local JVM, currently empty).
> * Written NetworkPackageTest based on NetworkPackageTest of kdeconnect-kde.
> * Written a basic DeviceTest, that tests functionality for Device class.
> 
> 
> Diffs
> -----
> 
>   build.gradle fd4dabe 
>   src/org/kde/kdeconnect/Device.java a8a25c7 
>   src/org/kde/kdeconnect/NetworkPackage.java e5a777e 
>   tests/org/kde/kdeconnect/DeviceTest.java PRE-CREATION 
>   tests/org/kde/kdeconnect/NetworkPackageTest.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124044/diff/
> 
> 
> Testing
> -------
> 
> Application builds properly
> Tests run successfully
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150609/8077af5f/attachment.html>