Review Request 121980: Added progress bar in notification while sending file.
Vineet Garg
grg.vineet at gmail.com
Sun Jan 18 00:41:24 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121980/
-----------------------------------------------------------
(Updated Jan. 18, 2015, 12:41 a.m.)
Status
------
This change has been marked as submitted.
Review request for kdeconnect and Albert Vaca Cintora.
Repository: kdeconnect-android
Description
-------
Added progress bar in notification while sending file.
Current changes:
* Renamed SendPackageFinishedCallback -> SendPackageStatusCallback and added progressChanged to it.
* Made necessary changes so that the callback instance can reach to sendPayload for getting progress.
* Made changes in ShareToReceiver to show progress.
Diffs
-----
res/values/strings.xml 23d10dc
src/org/kde/kdeconnect/Backends/BaseLink.java 242ff67
src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java ca81c13
src/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java 19038bb
src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLink.java 0461cf1
src/org/kde/kdeconnect/Device.java b9a876b
src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java 1e7e509
src/org/kde/kdeconnect/Plugins/SharePlugin/ShareToReceiver.java 170b7eb
Diff: https://git.reviewboard.kde.org/r/121980/diff/
Testing
-------
Testing done for both file and content.
Current issues:
* sendSuccessful is called much before during file is being sent.
* Exception in onNotificationPosted due to early call of sendSuccessful.
Here is logcat output : http://pastebin.com/MvznkrAd
Thanks,
Vineet Garg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150118/0a92ddaa/attachment.html>
More information about the KDEConnect
mailing list