Review Request 122020: Make a bluetooth backend for Android

Saikrishna Arcot saiarcot895 at gmail.com
Mon Jan 12 20:24:51 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122020/
-----------------------------------------------------------

Review request for kdeconnect.


Repository: kdeconnect-android


Description
-------

(Note that this isn't ready for merging yet.)

This is an initial implementation of a bluetooth backend. This backend implementation can be run only on Android 4.0.2 or higher. There are several things that need to be worked out.

1. When requesting permission to enable Bluetooth (if it's not already enabled), `startActivityForResult` needs to be called. However, this must be called by a class that implements `Activity`. One possible solution is to call this on the home screen. Another is to just not request it.
2. Options for enabling the Bluetooth backend need to be added to the settings window.
3. Some sections of code may warrant a new thread being created, as they may take a while to run.


Diffs
-----

  AndroidManifest.xml 6cbe4a7830cfe416fe98e42be143c0f26f2bf1e8 
  src/org/kde/kdeconnect/Backends/BluetoothBackend/BluetoothLink.java PRE-CREATION 
  src/org/kde/kdeconnect/Backends/BluetoothBackend/BluetoothLinkProvider.java PRE-CREATION 
  src/org/kde/kdeconnect/BackgroundService.java 576425cf568e4b223d9840842803d7adabf6b990 

Diff: https://git.reviewboard.kde.org/r/122020/diff/


Testing
-------

Installed on my Android 4.1.2, and it correctly detected that there are 2 bonded devices. No crashes.

Note that since the KDE side doesn't have a bluetooth backend, much of the code wasn't executed.


Thanks,

Saikrishna Arcot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150112/311d7282/attachment.html>


More information about the KDEConnect mailing list