Review Request 121910: Added progress bar in notification while receiving file.

[Vineet Garg]

> On Jan. 9, 2015, 5:37 a.m., Albert Vaca Cintora wrote:
> > src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java, line 155
> > <https://git.reviewboard.kde.org/r/121910/diff/1/?file=339032#file339032line155>
> >
> >     If the file transfer has no fileLength, then the notification will never be built. Make sure you build it once before entering the loop. Also, if it has no fileLength you should not setProgress() at all in the builder in the first place.

I set the indeterminate flag in builder to true, this will be OK in case where we don't know the file length, but forgot to build and notify. My home internet connection is currently down, I will patch it up soon.


- Vineet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121910/#review73547
-----------------------------------------------------------


On Jan. 8, 2015, 7:57 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121910/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 7:57 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> It's little bit annoying while transfering large files through KDEConnect. Now added a progress bar in notification through which user can see the progress as file is recieved.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java 479692f 
> 
> Diff: https://git.reviewboard.kde.org/r/121910/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150109/6d8e4342/attachment-0001.html>