Review Request 121910: Added progress bar in notification while receiving file.

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121910/#review73547
-----------------------------------------------------------


Good job! This was missing and it's going to be useful :) Just one issue: for some files we don't know the length, and your patch won't work well in this case. I added some comments below for you to fix this.


src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java
<https://git.reviewboard.kde.org/r/121910/#comment51199>

    Rename noti -> builder



src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java
<https://git.reviewboard.kde.org/r/121910/#comment51200>

    If the file transfer has no fileLength, then the notification will never be built. Make sure you build it once before entering the loop. Also, if it has no fileLength you should not setProgress() at all in the builder in the first place.


- Albert Vaca Cintora


On gen. 8, 2015, 8:57 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121910/
> -----------------------------------------------------------
> 
> (Updated gen. 8, 2015, 8:57 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> It's little bit annoying while transfering large files through KDEConnect. Now added a progress bar in notification through which user can see the progress as file is recieved.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java 479692f 
> 
> Diff: https://git.reviewboard.kde.org/r/121910/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150109/265a38d3/attachment.html>