Review Request 121687: Added support to filter notifications according to applications

[Vineet Garg]

> On Jan. 7, 2015, 6:46 a.m., Albert Vaca Cintora wrote:
> > src/org/kde/kdeconnect/Plugins/NotificationsPlugin/AppDatabase.java, line 57
> > <https://git.reviewboard.kde.org/r/121687/diff/2/?file=338286#file338286line57>
> >
> >     A lot of people complains about the Google Now notifications appearing all the time in their desktops. Can we add by default to the database that we don't want notifications from Google Now? The app that creates them is "Google Search".
> >     
> >     Also will be a good idea to also disable our own KDE Connect notifications (and maybe some others in a future).

Yes, it just ignores system apps that are the part of Android OS and covers all other apps including all Google apps and user installed apps.


> On Jan. 7, 2015, 6:46 a.m., Albert Vaca Cintora wrote:
> > src/org/kde/kdeconnect/Plugins/NotificationsPlugin/AppDatabase.java, line 125
> > <https://git.reviewboard.kde.org/r/121687/diff/2/?file=338286#file338286line125>
> >
> >     If an app is not present in the database you return false. But when adding new apps to the database (addNewlyInstalledApps), their default value is true. I think this is incoherent, am I wrong?

Yes, this is my mistake left out while reversing that database behaviour, that is by default all apps should be true.
I missed this :(


> On Jan. 7, 2015, 6:46 a.m., Albert Vaca Cintora wrote:
> > src/org/kde/kdeconnect/UserInterface/PluginSettingsActivity.java, lines 37-41
> > <https://git.reviewboard.kde.org/r/121687/diff/2/?file=338289#file338289line37>
> >
> >     Adding an "if" for this specific plugin is kind of ugly... isn't there any other way to do it?

Yeah, its a little bit ugly, but in all other plugins hardcoded preferences are used and I can't do it with this. Currently I am not aware of any other method but I will look at it.


- Vineet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121687/#review73320
-----------------------------------------------------------


On Jan. 5, 2015, 7:24 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121687/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2015, 7:24 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Notification sync settings is added where user can select applications for which he don't want to see notifications.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 6cbe4a7 
>   res/layout/activity_notification_filter.xml PRE-CREATION 
>   res/values/strings.xml 8337783 
>   src/org/kde/kdeconnect/Plugins/NotificationsPlugin/AppDatabase.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java f54c48f 
>   src/org/kde/kdeconnect/UserInterface/PluginSettingsActivity.java abe1db1 
> 
> Diff: https://git.reviewboard.kde.org/r/121687/diff/
> 
> 
> Testing
> -------
> 
> Testing done on emuulator with Android Lollipop by sending pings and Whatsapp messages to emulator via physical device both for application selected for filter and not selected for filter.
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150108/3858824c/attachment.html>