Review Request 121687: Added support to filter notifications according to applications

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121687/#review73320
-----------------------------------------------------------


Added some more comments.


src/org/kde/kdeconnect/Plugins/NotificationsPlugin/AppDatabase.java
<https://git.reviewboard.kde.org/r/121687/#comment50991>

    A lot of people complains about the Google Now notifications appearing all the time in their desktops. Can we add by default to the database that we don't want notifications from Google Now? The app that creates them is "Google Search".
    
    Also will be a good idea to also disable our own KDE Connect notifications (and maybe some others in a future).



src/org/kde/kdeconnect/Plugins/NotificationsPlugin/AppDatabase.java
<https://git.reviewboard.kde.org/r/121687/#comment50995>

    If an app is not present in the database you return false. But when adding new apps to the database (addNewlyInstalledApps), their default value is true. I think this is incoherent, am I wrong?



src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java
<https://git.reviewboard.kde.org/r/121687/#comment50992>

    Is that a non-ascii character? :P



src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java
<https://git.reviewboard.kde.org/r/121687/#comment50993>

    Idem



src/org/kde/kdeconnect/UserInterface/PluginSettingsActivity.java
<https://git.reviewboard.kde.org/r/121687/#comment50994>

    Adding an "if" for this specific plugin is kind of ugly... isn't there any other way to do it?


- Albert Vaca Cintora


On gen. 5, 2015, 8:24 a.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121687/
> -----------------------------------------------------------
> 
> (Updated gen. 5, 2015, 8:24 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Notification sync settings is added where user can select applications for which he don't want to see notifications.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 6cbe4a7 
>   res/layout/activity_notification_filter.xml PRE-CREATION 
>   res/values/strings.xml 8337783 
>   src/org/kde/kdeconnect/Plugins/NotificationsPlugin/AppDatabase.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java f54c48f 
>   src/org/kde/kdeconnect/UserInterface/PluginSettingsActivity.java abe1db1 
> 
> Diff: https://git.reviewboard.kde.org/r/121687/diff/
> 
> 
> Testing
> -------
> 
> Testing done on emuulator with Android Lollipop by sending pings and Whatsapp messages to emulator via physical device both for application selected for filter and not selected for filter.
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150107/57716d0c/attachment-0001.html>