Review Request 122486: Tried to fix some bugs in mpris notification and add Expandable notification.

[Chandramouleshwar Sanivarapu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122486/
-----------------------------------------------------------

(Updated Feb. 14, 2015, 3:39 p.m.)


Review request for kdeconnect and Albert Vaca Cintora.


Changes
-------

added expandable notification and fixed some bugs in mpris notification.


Summary (updated)
-----------------

Tried to fix some bugs in mpris notification and add Expandable notification.


Repository: kdeconnect-android


Description (updated)
-------

Fixed some bugs in mpris notification in the 'feature/noti-mediacontrol' branch

1.Merge mester in this branch
2.Dismiss the notification on closing the app
3.Dismiss the notification when the music player is closed
4.Make the notification visible in lockscreen lollipop
5.Chage the background and icon of the notification
6.Add expandable notification


Diffs (updated)
-----

  res/layout/mpris_big_notification.xml PRE-CREATION 
  res/layout/mpris_notification.xml c70d760 
  res/values-ar/strings.xml PRE-CREATION 
  res/values-bg/strings.xml 730b47b 
  res/values-bs/strings.xml 94d7918 
  res/values-ca/strings.xml 277abe4 
  res/values-cs/strings.xml 74f5bcd 
  res/values-da/strings.xml 94ae3bd 
  res/values-de/strings.xml 7f290b2 
  res/values-es/strings.xml cffb85a 
  res/values-fi/strings.xml 4c845bf 
  res/values-fr/strings.xml 9596ce2 
  res/values-hu/strings.xml 87127a9 
  res/values-it/strings.xml 8e26ec9 
  res/values-ja/strings.xml 7c4d5ac 
  res/values-ko/strings.xml ff2c9cc 
  res/values-lt/strings.xml 7c4d5ac 
  res/values-nl/strings.xml 3696834 
  res/values-pl/strings.xml 3545803 
  res/values-pt-rBR/strings.xml d5f4656 
  res/values-pt/strings.xml 2076573 
  res/values-ro/strings.xml 56a15b8 
  res/values-ru/strings.xml d914c38 
  res/values-sk/strings.xml 9b4b984 
  res/values-sv/strings.xml 75cd035 
  res/values-uk/strings.xml 2b039d4 
  res/values/dimens.xml 47c8224 
  res/values/strings.xml 23d10dc 
  res/values/styles.xml bf65b14 
  src/org/kde/kdeconnect/Backends/BaseLink.java 242ff67 
  src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java ca81c13 
  src/org/kde/kdeconnect/Backends/LanBackend/LanLinkProvider.java 19038bb 
  src/org/kde/kdeconnect/Backends/LoopbackBackend/LoopbackLink.java 0461cf1 
  src/org/kde/kdeconnect/Device.java b9a876b 
  src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java b601ddd 
  src/org/kde/kdeconnect/Plugins/MprisPlugin/NotificationPanel.java ec4e83d 
  src/org/kde/kdeconnect/Plugins/MprisPlugin/RemoteControlClientManager.java e1da548 
  src/org/kde/kdeconnect/Plugins/NotificationsPlugin/AppDatabase.java 2dbc249 
  src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java 0beff93 
  src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java add8ecf 
  src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java 1e7e509 
  src/org/kde/kdeconnect/Plugins/SharePlugin/ShareToReceiver.java 170b7eb 
  src/org/kde/kdeconnect/UserInterface/MainActivity.java de6aee7 
  AndroidManifest.xml de48c65 

Diff: https://git.reviewboard.kde.org/r/122486/diff/


Testing
-------

All testings done on android 4.4.4
All the above noted features worked well on the device.

Not tested:
Lockscreen notification in lollipop


Thanks,

Chandramouleshwar  Sanivarapu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150214/a57a8809/attachment.html>