Review Request 122486: tried to fix some bugs in mpris notification

[Vineet Garg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122486/#review76029
-----------------------------------------------------------


You uploaded the wrong patch file or forget to commit. This is patch file for last two commits of origin/feature/noti-mediacontrol.

- Vineet Garg


On Feb. 8, 2015, 7:34 p.m., Chandramouleshwar  Sanivarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122486/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2015, 7:34 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Fixed some bugs in mpris notification in the 'feature/noti-mediacontrol' branch
> 
> 1.Merge mester in this branch
> 2.Dismiss the notification on closing the app
> 3.Dismiss the notification when the music player is closed
> 4.Make the notification visible in lockscreen lollipop
> 5.Chage the background and icon of the notification
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 629a7ada3d1418724081e00fe5a862b326892012 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java 22181accf0aba3a7185877cd87c07058534a9035 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MusicControlReceiver.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/NotificationPanel.java 4d5fa5a191ca53aaab13f18eeccd37a1144b4d14 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/NotificationReturnSlot.java 244eb552aae0730d996b448af6f3a68f51782c3a 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/RemoteControlClientManager.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122486/diff/
> 
> 
> Testing
> -------
> 
> All testings done on android 4.4.4
> All the above noted features worked well on the device.
> 
> Not tested:
> Lockscreen notification in lollipop
> 
> 
> Thanks,
> 
> Chandramouleshwar  Sanivarapu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150214/5a1592ca/attachment.html>