Review Request 126273: Fix loosing already known plugins on reloading

Holger Kaelberer holger.k at elberer.de
Mon Dec 7 21:10:49 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126273/
-----------------------------------------------------------

Review request for kdeconnect.


Repository: kdeconnect-android


Description
-------

I am having problems with latest git master's HEAD. Seems that a device's pluginsByIncomingInterface are lost after different events (like e.g. orientation changes), such that all plugin-specific incoming packets end up in nirvana. Is this known? Am I the only one with that problem?

This patch fixes the issue for me.

I'm not sure though, whether these repeated calls to reloadPluginsFromSettings() are to be blamed and fixed as root cause.


Diffs
-----

  src/org/kde/kdeconnect/Device.java 697ea45 

Diff: https://git.reviewboard.kde.org/r/126273/diff/


Testing
-------

Yep, seems to fix the issue.


Thanks,

Holger Kaelberer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20151207/f50de4d0/attachment.html>


More information about the KDEConnect mailing list