Review Request 125179: notifications: accept remote notifications

[Holger Kaelberer]

> On Dec. 7, 2015, 11:47 a.m., Albert Vaca Cintora wrote:
> > src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java, line 340
> > <https://git.reviewboard.kde.org/r/125179/diff/2/?file=418489#file418489line340>
> >
> >     I don't think we are checking this property in the NotificationsReceiver, so probably we should.

It is already checked in NotificationPlugin.sendNotification()

BTW: I am having problems with latest git master's HEAD. Seems that pluginsByIncomingInterface are lost after different events (like e.g. orientation changes), such that all plugin-specific incoming packets end up in nirvana. Is this known? Am I the only one with that problem?


- Holger


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125179/#review89211
-----------------------------------------------------------


On Dec. 7, 2015, 8:44 p.m., Holger Kaelberer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125179/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2015, 8:44 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> - request notifications onCreate
> - create (tagged) local notifications for remote notif
> - propagte cancellation to remote side when dismissed locally
> 
> This catches up with recent notifications changes on kdeconnect-master (https://git.reviewboard.kde.org/r/125140/). Handles only new OSes with API level > 17. Support for olders is coming ...
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java efa37d1 
> 
> Diff: https://git.reviewboard.kde.org/r/125179/diff/
> 
> 
> Testing
> -------
> 
> Tested with tablet (api level 21) against desktop with patched master.
> 
> 
> Thanks,
> 
> Holger Kaelberer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20151207/64574f89/attachment.html>