Review Request 125140: [kdeconnect-kde] initial support for desktop-to-XXX notifications

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125140/#review89001
-----------------------------------------------------------



plugins/notifications/notifyingapplicationmodel.h (line 34)
<https://git.reviewboard.kde.org/r/125140/#comment60927>

    Remove the numbers, no need.



plugins/notifications/notifyingapplicationmodel.h (line 60)
<https://git.reviewboard.kde.org/r/125140/#comment60928>

    Why would it need locking? dbus also lives in the gui thread.


Do you think it would be possible to test it somehow? Maybe we can get inspired in the sharefiletest.cpp there?

Otherwise, ship it. Looks good and I'd like to give it a try!

- Aleix Pol Gonzalez


On Nov. 27, 2015, 9:18 p.m., Holger Kaelberer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125140/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2015, 9:18 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Eavesdrop on the Notify call of the org.freedesktop.Notifications dbus-interface, proxy all caught notifications to our peer device and track them in the internal notifications-list.
> 
> Also fix "cancel" requests from peer devices, by cutting of kdeconnect-android's id-prefix.
> 
> 
> Diffs
> -----
> 
>   core/kdeconnectpluginconfig.h 09bf68e 
>   core/kdeconnectpluginconfig.cpp 980235c 
>   plugins/notifications/CMakeLists.txt 41c5b78 
>   plugins/notifications/kdeconnect_notifications_config.desktop PRE-CREATION 
>   plugins/notifications/notifications_config.h PRE-CREATION 
>   plugins/notifications/notifications_config.cpp PRE-CREATION 
>   plugins/notifications/notifications_config.ui PRE-CREATION 
>   plugins/notifications/notificationsdbusinterface.h 21d5a6a 
>   plugins/notifications/notificationsdbusinterface.cpp 3c504c6 
>   plugins/notifications/notificationslistener.h PRE-CREATION 
>   plugins/notifications/notificationslistener.cpp PRE-CREATION 
>   plugins/notifications/notificationsplugin.h 7cc67c5 
>   plugins/notifications/notificationsplugin.cpp badb5d3 
>   plugins/notifications/notifyingapplication.h PRE-CREATION 
>   plugins/notifications/notifyingapplication.cpp PRE-CREATION 
>   plugins/notifications/notifyingapplicationmodel.h PRE-CREATION 
>   plugins/notifications/notifyingapplicationmodel.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125140/diff/
> 
> 
> Testing
> -------
> 
> I tested with my (patched) tablet, works fine.
> 
> 
> File Attachments
> ----------------
> 
> config screenshot 1
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/11/27/975e2005-2baa-4584-9bc4-dd406ebe2ae1__notifications-config0.jpg
> config screeshot 2
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/11/27/09c97354-19ca-4606-81b8-61cdb3fa2af0__notifications-config1.jpg
> 
> 
> Thanks,
> 
> Holger Kaelberer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20151201/4c50fd0c/attachment.html>