Review Request 124551: One Time Share - Enables to share files android to android without pairing devices

[Ashish Bansal]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124551/#review84554
-----------------------------------------------------------



src/org/kde/kdeconnect/Plugins/SharePlugin/OneTimeReceiveActivity.java (line 41)
<https://git.reviewboard.kde.org/r/124551/#comment58529>

    Last night, I was talking about this variable. Is it fine, or need some changes?


- Ashish Bansal


On Aug. 29, 2015, 7:23 a.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124551/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2015, 7:23 a.m.)
> 
> 
> Review request for kdeconnect, Àlex Fiestas, Albert Vaca Cintora, and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Select file and click Share via KDE Connect and it will show you two sections, Share to Reachable and Share to Paired. Choose Share to Reachable and it'll show the options to Accept/Reject file.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 0da70ba 
>   res/layout/activity_one_time_receive.xml PRE-CREATION 
>   res/layout/activity_share.xml PRE-CREATION 
>   res/values/strings.xml c128342 
>   src/org/kde/kdeconnect/NetworkPackage.java a4ef7d0 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/OneTimeReceiveActivity.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java ab8154a 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java 479c790 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/TransferFile.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124551/diff/
> 
> 
> Testing
> -------
> 
> File gets trasferred successfully.
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150829/d8aff52f/attachment.html>