Review Request 124551: One Time Share - Enables to share files android to android without pairing devices

[Ashish Bansal]

> On Aug. 14, 2015, 5:22 a.m., Ashish Bansal wrote:
> > src/org/kde/kdeconnect/Device.java, line 480
> > <https://git.reviewboard.kde.org/r/124551/diff/1/?file=388842#file388842line480>
> >
> >     First of all sorry, I forgot to pull the latest changes and so this doesn't apply on latest master. I can fix this up.
> >     
> >     I wrote it some months back. Now I was checking this and I myself didn't like this approach, hardcoding the plugin name. Can someone please suggest be better design/approach for this?
> 
> Albert Vaca Cintora wrote:
>     Plugin could be able to register themselves in the Device class to receive unencrypted packages, something like this:
>     
>     device.registerUnpairedPackageListener(callback);
>     
>     If the device receives an unencrypted package and its not a pairing package, it will call the callbacks for the plugins that registered for unencrypted packages to see if anyone can handle it.

Thanks for this approach!

By the way, Now it can be applied to master.


- Ashish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124551/#review83795
-----------------------------------------------------------


On Aug. 28, 2015, 8:10 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124551/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 8:10 p.m.)
> 
> 
> Review request for kdeconnect, Àlex Fiestas, Albert Vaca Cintora, and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Select file and click Share via KDE Connect and it will show you two sections, Share to Reachable and Share to Paired. Choose Share to Reachable and it'll show the options to Accept/Reject file.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 0da70ba 
>   res/layout/activity_one_time_receive.xml PRE-CREATION 
>   res/layout/activity_share.xml PRE-CREATION 
>   res/values/strings.xml c128342 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/OneTimeReceiveActivity.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java ab8154a 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java 479c790 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/TransferFile.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124551/diff/
> 
> 
> Testing
> -------
> 
> NetworkPackage Payload gets lost due to which file is not received.
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150828/2b7a844e/attachment.html>