Review Request 124551: One Time Share - Enables to share files android to android without pairing devices

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124551/#review84550
-----------------------------------------------------------



res/values/strings.xml (lines 118 - 119)
<https://git.reviewboard.kde.org/r/124551/#comment58525>

    "reachable" is a term we want to stop exposing to the user as part of coming UX changes. Change to:
    Share to...
    Share to unpaired device...



src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java (lines 93 - 94)
<https://git.reviewboard.kde.org/r/124551/#comment58519>

    Don't remove the try catch.



src/org/kde/kdeconnect/Plugins/SharePlugin/TransferFile.java (lines 57 - 59)
<https://git.reviewboard.kde.org/r/124551/#comment58524>

    You always call setContext after creating a new instance, context should be in the constructor. Actually even the NetworkPackage could be part of the constructor.



src/org/kde/kdeconnect/Plugins/SharePlugin/TransferFile.java (line 98)
<https://git.reviewboard.kde.org/r/124551/#comment58520>

    Try-catch



src/org/kde/kdeconnect/Plugins/SharePlugin/TransferFile.java (line 119)
<https://git.reviewboard.kde.org/r/124551/#comment58521>

    Try-catch



src/org/kde/kdeconnect/Plugins/SharePlugin/TransferFile.java (line 157)
<https://git.reviewboard.kde.org/r/124551/#comment58523>

    "onetimeshare"? should be device name?



src/org/kde/kdeconnect/Plugins/SharePlugin/TransferFile.java (line 175)
<https://git.reviewboard.kde.org/r/124551/#comment58522>

    Try-catch


- Albert Vaca Cintora


On Aug. 28, 2015, 1:10 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124551/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 1:10 p.m.)
> 
> 
> Review request for kdeconnect, Àlex Fiestas, Albert Vaca Cintora, and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Select file and click Share via KDE Connect and it will show you two sections, Share to Reachable and Share to Paired. Choose Share to Reachable and it'll show the options to Accept/Reject file.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 0da70ba 
>   res/layout/activity_one_time_receive.xml PRE-CREATION 
>   res/layout/activity_share.xml PRE-CREATION 
>   res/values/strings.xml c128342 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/OneTimeReceiveActivity.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java ab8154a 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java 479c790 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/TransferFile.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124551/diff/
> 
> 
> Testing
> -------
> 
> NetworkPackage Payload gets lost due to which file is not received.
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150828/5f47cb76/attachment-0001.html>