Review Request 124551: One Time Share - Enables to share files android to android without pairing devices

[Albert Vaca Cintora]

> On Aug. 28, 2015, 1:14 p.m., Ashish Bansal wrote:
> > src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java, line 232
> > <https://git.reviewboard.kde.org/r/124551/diff/2/?file=399493#file399493line232>
> >
> >     Here when I serialize network package to pass it to next activity, some of its data(payload) gets lost. 
> >     I can create one static list of networkpackages in this plugin and access it using package id but I think it is very bad design/approach.
> >     
> >     Can you please suggest me something?

There is no good solution for passing complex objects between activities in Android, you will need the hacky static variable.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124551/#review84549
-----------------------------------------------------------


On Aug. 28, 2015, 1:10 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124551/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 1:10 p.m.)
> 
> 
> Review request for kdeconnect, Àlex Fiestas, Albert Vaca Cintora, and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Select file and click Share via KDE Connect and it will show you two sections, Share to Reachable and Share to Paired. Choose Share to Reachable and it'll show the options to Accept/Reject file.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 0da70ba 
>   res/layout/activity_one_time_receive.xml PRE-CREATION 
>   res/layout/activity_share.xml PRE-CREATION 
>   res/values/strings.xml c128342 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/OneTimeReceiveActivity.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java ab8154a 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java 479c790 
>   src/org/kde/kdeconnect/Plugins/SharePlugin/TransferFile.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124551/diff/
> 
> 
> Testing
> -------
> 
> NetworkPackage Payload gets lost due to which file is not received.
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150828/d71c0e2b/attachment.html>