Review Request 124906: Load plugins even if device is not paired but reachable

[Ashish Bansal]

> On Aug. 24, 2015, 6:58 p.m., Albert Vaca Cintora wrote:
> > Instead of this, can you add a method in Plugin that is "boolean listensToUnpairedDevices()",  so you can only load the ones that return true? If we do this, we can actually use that instead of the "registerUnpairedPackageListener" and remove that method. Can you do that as part of this CR?

Sure :)


- Ashish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124906/#review84300
-----------------------------------------------------------


On Aug. 25, 2015, 5:53 a.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124906/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 5:53 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Plugins should be loaded even if device is not paired, otherwise they won't be able to listen to NetworkPackages from the unpaired devices.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Plugins/PluginFactory.java e063d85 
>   src/org/kde/kdeconnect/Device.java 09c7549 
>   src/org/kde/kdeconnect/Plugins/Plugin.java eff176f 
> 
> Diff: https://git.reviewboard.kde.org/r/124906/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150825/aede7c79/attachment.html>