Review Request 124906: Load plugins even if device is not paired but reachable

Albert Vaca Cintora albertvaka at gmail.com
Mon Aug 24 18:58:31 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124906/#review84300
-----------------------------------------------------------


Instead of this, can you add a method in Plugin that is "boolean listensToUnpairedDevices()",  so you can only load the ones that return true? If we do this, we can actually use that instead of the "registerUnpairedPackageListener" and remove that method. Can you do that as part of this CR?

- Albert Vaca Cintora


On Aug. 24, 2015, 11:53 a.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124906/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2015, 11:53 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Plugins should be loaded even if device is not paired, otherwise they won't be able to listen to NetworkPackages from the unpaired devices.
> 
> 
> Diffs
> -----
> 
>   src/org/kde/kdeconnect/Device.java 09c7549 
> 
> Diff: https://git.reviewboard.kde.org/r/124906/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150824/b67da959/attachment.html>


More information about the KDEConnect mailing list