Review Request 124857: kdeconnect-kde: Fix various krazy2 warnings

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124857/#review84145
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Vaca Cintora


On Aug. 20, 2015, 10:28 p.m., Boris Egorov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124857/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 10:28 p.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Fix following krazy2 warning types:
> [explicit], [endswithnewline], [doublequote_chars], [includes],
> [normalize], [postfixop], [spelling]
> 
> See http://ebn.kde.org/krazy/reports/playground/base/kdeconnect-kde/index.html for details
> 
> SLOT/SIGNAL normalization done with Qt normalize utility:
> https://github.com/qtproject/qtrepotools/tree/master/util/normalize
> 
> 
> Diffs
> -----
> 
>   core/backends/lan/lanlinkprovider.cpp f5d2b22 
>   core/backends/lan/uploadjob.h 12b6f7e 
>   core/backends/lan/uploadjob.cpp b0d35fc 
>   core/backends/lan/socketlinereader.h b3be55a 
>   core/core_debug.h 33504de 
>   core/daemon.h 674ca01 
>   core/daemon.cpp af4c67b 
>   core/dbushelper.h 43b2286 
>   core/dbushelper.cpp e188126 
>   core/device.cpp c2dc609 
>   core/kdeconnectconfig.cpp 919505c 
>   core/networkpackage.h 6a0bf9c 
>   interfaces/dbusinterfaces.h 2f51599 
>   interfaces/devicesmodel.h e96af81 
>   interfaces/devicesmodel.cpp 11b56da 
>   interfaces/devicessortproxymodel.h 54b7a0b 
>   interfaces/interfaces_debug.h 5083239 
>   interfaces/modeltest.h 38b6b2b 
>   interfaces/modeltest.cpp 9259487 
>   interfaces/notificationsmodel.h c54ef65 
>   interfaces/notificationsmodel.cpp aba4573 
>   kio/kiokdeconnect.cpp 0ac875d 
>   plasmoid/declarativeplugin/processrunner.h 20e86e6 
>   plasmoid/declarativeplugin/responsewaiter.h a2aec19 
>   plasmoid/declarativeplugin/responsewaiter.cpp e909842 
>   plugins/mpriscontrol/mpriscontrolplugin.cpp 8318217 
>   plugins/notifications/notification_debug.h 09da52f 
>   plugins/sftp/mounter.cpp 916b102 
>   plugins/sftp/sftp_debug.h 30da8f8 
>   plugins/share/autoclosingqfile.h bea1ea1 
>   plugins/share/share_debug.h d6cf416 
> 
> Diff: https://git.reviewboard.kde.org/r/124857/diff/
> 
> 
> Testing
> -------
> 
> Build
> 
> 
> Thanks,
> 
> Boris Egorov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150821/9a849b80/attachment.html>