<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124857/">https://git.reviewboard.kde.org/r/124857/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Albert Vaca Cintora</p>
<br />
<p>On August 20th, 2015, 10:28 p.m. PDT, Boris Egorov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect and Albert Vaca Cintora.</div>
<div>By Boris Egorov.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2015, 10:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix following krazy2 warning types:
[explicit], [endswithnewline], [doublequote_chars], [includes],
[normalize], [postfixop], [spelling]</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See http://ebn.kde.org/krazy/reports/playground/base/kdeconnect-kde/index.html for details</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">SLOT/SIGNAL normalization done with Qt normalize utility:
https://github.com/qtproject/qtrepotools/tree/master/util/normalize</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/backends/lan/lanlinkprovider.cpp <span style="color: grey">(f5d2b22)</span></li>
<li>core/backends/lan/uploadjob.h <span style="color: grey">(12b6f7e)</span></li>
<li>core/backends/lan/uploadjob.cpp <span style="color: grey">(b0d35fc)</span></li>
<li>core/backends/lan/socketlinereader.h <span style="color: grey">(b3be55a)</span></li>
<li>core/core_debug.h <span style="color: grey">(33504de)</span></li>
<li>core/daemon.h <span style="color: grey">(674ca01)</span></li>
<li>core/daemon.cpp <span style="color: grey">(af4c67b)</span></li>
<li>core/dbushelper.h <span style="color: grey">(43b2286)</span></li>
<li>core/dbushelper.cpp <span style="color: grey">(e188126)</span></li>
<li>core/device.cpp <span style="color: grey">(c2dc609)</span></li>
<li>core/kdeconnectconfig.cpp <span style="color: grey">(919505c)</span></li>
<li>core/networkpackage.h <span style="color: grey">(6a0bf9c)</span></li>
<li>interfaces/dbusinterfaces.h <span style="color: grey">(2f51599)</span></li>
<li>interfaces/devicesmodel.h <span style="color: grey">(e96af81)</span></li>
<li>interfaces/devicesmodel.cpp <span style="color: grey">(11b56da)</span></li>
<li>interfaces/devicessortproxymodel.h <span style="color: grey">(54b7a0b)</span></li>
<li>interfaces/interfaces_debug.h <span style="color: grey">(5083239)</span></li>
<li>interfaces/modeltest.h <span style="color: grey">(38b6b2b)</span></li>
<li>interfaces/modeltest.cpp <span style="color: grey">(9259487)</span></li>
<li>interfaces/notificationsmodel.h <span style="color: grey">(c54ef65)</span></li>
<li>interfaces/notificationsmodel.cpp <span style="color: grey">(aba4573)</span></li>
<li>kio/kiokdeconnect.cpp <span style="color: grey">(0ac875d)</span></li>
<li>plasmoid/declarativeplugin/processrunner.h <span style="color: grey">(20e86e6)</span></li>
<li>plasmoid/declarativeplugin/responsewaiter.h <span style="color: grey">(a2aec19)</span></li>
<li>plasmoid/declarativeplugin/responsewaiter.cpp <span style="color: grey">(e909842)</span></li>
<li>plugins/mpriscontrol/mpriscontrolplugin.cpp <span style="color: grey">(8318217)</span></li>
<li>plugins/notifications/notification_debug.h <span style="color: grey">(09da52f)</span></li>
<li>plugins/sftp/mounter.cpp <span style="color: grey">(916b102)</span></li>
<li>plugins/sftp/sftp_debug.h <span style="color: grey">(30da8f8)</span></li>
<li>plugins/share/autoclosingqfile.h <span style="color: grey">(bea1ea1)</span></li>
<li>plugins/share/share_debug.h <span style="color: grey">(d6cf416)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124857/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>