Review Request 123345: Find my phone plugin for kdeconnect android

[Ashish Bansal]

> On April 12, 2015, 6:11 p.m., Vineet Garg wrote:
> > It was a GCI task, and is already implemented. Can't remember the reason why it was not merged with master, but still there is a branch called "findmyphone". You will find the reason in mail logs and can work accordingly.
> > Also be sure to revert the changes in audio services like stream volume etc. so that user don't have to again set it audio preferences.

Ah, my bad! I was just checking things from here [1] and didn't know that it was GCI task and re-done the task :(

Anyway If that branch works fine, then cool, Just discard this.

[1] https://albertvaka.wordpress.com/2014/10/23/kde-connect-feature-brainstorming/


- Ashish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123345/#review78867
-----------------------------------------------------------


On April 12, 2015, 5:56 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123345/
> -----------------------------------------------------------
> 
> (Updated April 12, 2015, 5:56 p.m.)
> 
> 
> Review request for kdeconnect, Albert Vaca Cintora and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> When invoked, this plugin plays phone's default ringtone at max volume even if it's at silent and turns if off on touching the Notification.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 556b06b 
>   res/values/strings.xml 6984ce6 
>   src/org/kde/kdeconnect/NetworkPackage.java e5a777e 
>   src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhonePlugin.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/PhoneFound.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/PluginFactory.java 0100690 
> 
> Diff: https://git.reviewboard.kde.org/r/123345/diff/
> 
> 
> Testing
> -------
> 
> Works Fine.
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150412/c99f3329/attachment-0001.html>