Review Request 123345: Find my phone plugin for kdeconnect android

[Vineet Garg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123345/#review78867
-----------------------------------------------------------


It was a GCI task, and is already implemented. Can't remember the reason why it was not merged with master, but still there is a branch called "findmyphone". You will find the reason in mail logs and can work accordingly.
Also be sure to revert the changes in audio services like stream volume etc. so that user don't have to again set it audio preferences.

- Vineet Garg


On April 12, 2015, 5:56 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123345/
> -----------------------------------------------------------
> 
> (Updated April 12, 2015, 5:56 p.m.)
> 
> 
> Review request for kdeconnect, Albert Vaca Cintora and Aleix Pol Gonzalez.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> When invoked, this plugin plays phone's default ringtone at max volume even if it's at silent and turns if off on touching the Notification.
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 556b06b 
>   res/values/strings.xml 6984ce6 
>   src/org/kde/kdeconnect/NetworkPackage.java e5a777e 
>   src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhonePlugin.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/PhoneFound.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/PluginFactory.java 0100690 
> 
> Diff: https://git.reviewboard.kde.org/r/123345/diff/
> 
> 
> Testing
> -------
> 
> Works Fine.
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150412/df882b68/attachment.html>