Review Request 123258: Removed notification because KIO already provides one.

[Ashish Bansal]

> On April 5, 2015, 4:08 a.m., Ashish Bansal wrote:
> > This is regarding the dialog box by kio "File Transfer over KDE Connect" which shows up the file transfer progress, right?
> > 
> > But when it completes up the transfer, it does not shows whether file transfer completed successfully or got failed.
> 
> Albert Vaca Cintora wrote:
>     KJob has setError() and setErrorText() for that pourpose, if they don't work maybe we are not calling them or not doing it properly.

okay


- Ashish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123258/#review78511
-----------------------------------------------------------


On April 5, 2015, 12:21 a.m., Albert Vaca Cintora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123258/
> -----------------------------------------------------------
> 
> (Updated April 5, 2015, 12:21 a.m.)
> 
> 
> Review request for kdeconnect, Aleix Pol Gonzalez and Ashish Bansal.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Removed notification because KIO already provides one.
> 
> 
> Diffs
> -----
> 
>   plugins/share/shareplugin.cpp ab0b441d9bedb47c148ad43594c269fe26bda5b4 
> 
> Diff: https://git.reviewboard.kde.org/r/123258/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Vaca Cintora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150405/c0bfca7a/attachment.html>