Review Request 123258: Removed notification because KIO already provides one.

[Albert Vaca Cintora]

> On April 4, 2015, 9:08 p.m., Ashish Bansal wrote:
> > This is regarding the dialog box by kio "File Transfer over KDE Connect" which shows up the file transfer progress, right?
> > 
> > But when it completes up the transfer, it does not shows whether file transfer completed successfully or got failed.

KJob has setError() and setErrorText() for that pourpose, if they don't work maybe we are not calling them or not doing it properly.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123258/#review78511
-----------------------------------------------------------


On April 4, 2015, 5:21 p.m., Albert Vaca Cintora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123258/
> -----------------------------------------------------------
> 
> (Updated April 4, 2015, 5:21 p.m.)
> 
> 
> Review request for kdeconnect, Aleix Pol Gonzalez and Ashish Bansal.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Removed notification because KIO already provides one.
> 
> 
> Diffs
> -----
> 
>   plugins/share/shareplugin.cpp ab0b441d9bedb47c148ad43594c269fe26bda5b4 
> 
> Diff: https://git.reviewboard.kde.org/r/123258/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Vaca Cintora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20150405/45d9660e/attachment.html>