Review Request 121104: Manual IP/host specification for pairing through VPN or separate netwoks

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121104/#review70495
-----------------------------------------------------------


I see that most of the code from CustomLinkProvider is shared with LanLinkProvider, so my suggestion is to merge them into one class to avoid having duplicate code to maintain. If you think there is a good reason to keep this in a separate plugin, then we should remove all the UDP-related code from here, because it's not used anymore. What do you think?


src/main/java/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java
<https://git.reviewboard.kde.org/r/121104/#comment49323>

    Do we really need to specify a port? If it is needed, how can it be working without it?



src/main/java/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java
<https://git.reviewboard.kde.org/r/121104/#comment49322>

    Why is this code commented? If it's not needed we should just remove it.


- Albert Vaca Cintora


On nov. 11, 2014, 3:01 p.m., Achilleas Koutsou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121104/
> -----------------------------------------------------------
> 
> (Updated nov. 11, 2014, 3:01 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Bugs: 326509
>     http://bugs.kde.org/show_bug.cgi?id=326509
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Created new backend (CustomLinkBackend) which reads a list of user-specified IP addresses or host names and attempts to send KDE-connect packets to them, bypassing the autodiscovery which usually happens via broadcast packets. This allows for the pairing and communication between two devices which are connected via a gateway (or route) that does not allow broadcasts (e.g., OpenVPN in tunnel mode, separate networks). This patch also adds a new menu and activity for adding and removing IP addresses and hostnames (Custom device list).
> 
> This resolves [bug 326509](https://bugs.kde.org/show_bug.cgi?id=326509).
> 
> 
> Diffs
> -----
> 
>   src/main/AndroidManifest.xml 886e27c 
>   src/main/java/org/kde/kdeconnect/Backends/CustomLinkBackend/CustomLink.java PRE-CREATION 
>   src/main/java/org/kde/kdeconnect/Backends/CustomLinkBackend/CustomLinkProvider.java PRE-CREATION 
>   src/main/java/org/kde/kdeconnect/BackgroundService.java c8d4e36 
>   src/main/java/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java PRE-CREATION 
>   src/main/java/org/kde/kdeconnect/UserInterface/MainActivity.java aba1336 
>   src/main/res/layout/custom_ip_list.xml PRE-CREATION 
>   src/main/res/menu/main.xml 189b036 
>   src/main/res/values/strings.xml 5801b31 
> 
> Diff: https://git.reviewboard.kde.org/r/121104/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Achilleas Koutsou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20141117/6e64156a/attachment.html>