<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121104/">https://git.reviewboard.kde.org/r/121104/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I see that most of the code from CustomLinkProvider is shared with LanLinkProvider, so my suggestion is to merge them into one class to avoid having duplicate code to maintain. If you think there is a good reason to keep this in a separate plugin, then we should remove all the UDP-related code from here, because it's not used anymore. What do you think?</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121104/diff/1/?file=327745#file327745line86" style="color: black; font-weight: bold; text-decoration: underline;">src/main/java/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">86</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// </span><span class="cs">TODO</span><span class="c1">: allow specifying port as well</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do we really need to specify a port? If it is needed, how can it be working without it?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121104/diff/1/?file=327745#file327745line111" style="color: black; font-weight: bold; text-decoration: underline;">src/main/java/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">111</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> private void initPreferences(final ListPreference ipListPref) {</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why is this code commented? If it's not needed we should just remove it.</p></pre>
</div>
</div>
<br />
<p>- Albert Vaca Cintora</p>
<br />
<p>On novembre 11th, 2014, 3:01 p.m. CET, Achilleas Koutsou wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Achilleas Koutsou.</div>
<p style="color: grey;"><i>Updated nov. 11, 2014, 3:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=326509">326509</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-android
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Created new backend (CustomLinkBackend) which reads a list of user-specified IP addresses or host names and attempts to send KDE-connect packets to them, bypassing the autodiscovery which usually happens via broadcast packets. This allows for the pairing and communication between two devices which are connected via a gateway (or route) that does not allow broadcasts (e.g., OpenVPN in tunnel mode, separate networks). This patch also adds a new menu and activity for adding and removing IP addresses and hostnames (Custom device list).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This resolves <a href="https://bugs.kde.org/show_bug.cgi?id=326509" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">bug 326509</a>.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/main/AndroidManifest.xml <span style="color: grey">(886e27c)</span></li>
<li>src/main/java/org/kde/kdeconnect/Backends/CustomLinkBackend/CustomLink.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Backends/CustomLinkBackend/CustomLinkProvider.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/BackgroundService.java <span style="color: grey">(c8d4e36)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/UserInterface/MainActivity.java <span style="color: grey">(aba1336)</span></li>
<li>src/main/res/layout/custom_ip_list.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/res/menu/main.xml <span style="color: grey">(189b036)</span></li>
<li>src/main/res/values/strings.xml <span style="color: grey">(5801b31)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121104/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>