Review Request 116972: android: Introducing a MPRIS remote control widget

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116972/#review53748
-----------------------------------------------------------


It looks nice so far, but in my opinion more work is needed before this can be merged for general usage. Updating without having to re-add the widget is a must, and also I would like a better user interface (at least, on my device looks weird: https://dl.dropboxusercontent.com/u/8820360/Screenshot_2014-03-22-12-48-40.png). For those who want to try it, I commited the changes to the branch "feature/mpris-widget".

- Albert Vaca Cintora


On March 22, 2014, 1:09 a.m., Valentin Rusu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116972/
> -----------------------------------------------------------
> 
> (Updated March 22, 2014, 1:09 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> This patch introduces an MPRIS widget.
> 
> The MPRIS widget can be used as a remote control for the active player on the paired device (e.g. my computer).
> When added to the android device screen, the widget searches for the active player, and if found, it will display the current device name, player and media title, along with three buttons (prev, play/pause, next). It receives notifications from the paired device and updates accordingly. Several widgets could be added on different screens. They'll get updated together, with the same information. The updates come from a dedicated background service. The background service stops when the last widget is removed from the screen.
> 
> If no player is found, then it will display a "waiting" message. However, current code is not yet able to get a notification from the paired device and update the widget accordingly. For the moment, the widget should be removed then added again to the screen in order to get it correctly updated if a player was started meanwhile on the paired device. That leads to the following TODO: figure-out how to get notifications when a new player is launched and started playing on the paired device. I suppose that these should come from the kded, in order to prevent periodic polling from the android device and the power surge it may induce.
> 
> Other features I'd like to propose for a future review:
> - volume adjusting,
> - open the MPRIS activity when clicked.
> 
> 
> Diffs
> -----
> 
>   gradle/wrapper/gradle-wrapper.properties 61e26f8 
>   kdeconnect-android.iml f7af481 
>   src/main/AndroidManifest.xml 5c1f748 
>   src/main/java/org/kde/kdeconnect/BackgroundService.java 8fe8db5 
>   src/main/java/org/kde/kdeconnect/Device.java 918e948 
>   src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java 07fae27 
>   src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java 4ad57be 
>   src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisWidgetProvider.java PRE-CREATION 
>   src/main/java/org/kde/kdeconnect/Plugins/Plugin.java a91016a 
>   src/main/res/layout/mpris_widget.xml PRE-CREATION 
>   src/main/res/values-v14/dimens.xml PRE-CREATION 
>   src/main/res/values/dimens.xml 47c8224 
>   src/main/res/values/strings.xml 977cae1 
>   src/main/res/xml/mpris_widget.xml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/116972/diff/
> 
> 
> Testing
> -------
> 
> Using it on my android phone (a Samsung Galaxy SIII with OmniROM and Android Kit Kat 4.4.2)
> 
> 
> Thanks,
> 
> Valentin Rusu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140322/dfe9026f/attachment.html>