<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116972/">https://git.reviewboard.kde.org/r/116972/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It looks nice so far, but in my opinion more work is needed before this can be merged for general usage. Updating without having to re-add the widget is a must, and also I would like a better user interface (at least, on my device looks weird: https://dl.dropboxusercontent.com/u/8820360/Screenshot_2014-03-22-12-48-40.png). For those who want to try it, I commited the changes to the branch "feature/mpris-widget".</pre>
<br />
<p>- Albert Vaca Cintora</p>
<br />
<p>On March 22nd, 2014, 1:09 a.m. CET, Valentin Rusu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Valentin Rusu.</div>
<p style="color: grey;"><i>Updated March 22, 2014, 1:09 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-android
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch introduces an MPRIS widget.
The MPRIS widget can be used as a remote control for the active player on the paired device (e.g. my computer).
When added to the android device screen, the widget searches for the active player, and if found, it will display the current device name, player and media title, along with three buttons (prev, play/pause, next). It receives notifications from the paired device and updates accordingly. Several widgets could be added on different screens. They'll get updated together, with the same information. The updates come from a dedicated background service. The background service stops when the last widget is removed from the screen.
If no player is found, then it will display a "waiting" message. However, current code is not yet able to get a notification from the paired device and update the widget accordingly. For the moment, the widget should be removed then added again to the screen in order to get it correctly updated if a player was started meanwhile on the paired device. That leads to the following TODO: figure-out how to get notifications when a new player is launched and started playing on the paired device. I suppose that these should come from the kded, in order to prevent periodic polling from the android device and the power surge it may induce.
Other features I'd like to propose for a future review:
- volume adjusting,
- open the MPRIS activity when clicked.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using it on my android phone (a Samsung Galaxy SIII with OmniROM and Android Kit Kat 4.4.2)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>gradle/wrapper/gradle-wrapper.properties <span style="color: grey">(61e26f8)</span></li>
<li>kdeconnect-android.iml <span style="color: grey">(f7af481)</span></li>
<li>src/main/AndroidManifest.xml <span style="color: grey">(5c1f748)</span></li>
<li>src/main/java/org/kde/kdeconnect/BackgroundService.java <span style="color: grey">(8fe8db5)</span></li>
<li>src/main/java/org/kde/kdeconnect/Device.java <span style="color: grey">(918e948)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java <span style="color: grey">(07fae27)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java <span style="color: grey">(4ad57be)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/MprisPlugin/MprisWidgetProvider.java <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/java/org/kde/kdeconnect/Plugins/Plugin.java <span style="color: grey">(a91016a)</span></li>
<li>src/main/res/layout/mpris_widget.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/res/values-v14/dimens.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/main/res/values/dimens.xml <span style="color: grey">(47c8224)</span></li>
<li>src/main/res/values/strings.xml <span style="color: grey">(977cae1)</span></li>
<li>src/main/res/xml/mpris_widget.xml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116972/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>