Review Request 116645: Simplify a lot the code in SocketLinearReader

[Àlex Fiestas]

> On March 7, 2014, 11:06 a.m., Albert Vaca Cintora wrote:
> > Will this test ever fail?

It actually allowed me to remember to skip empty "\n", so yes it can fail.


- Àlex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116645/#review52332
-----------------------------------------------------------


On March 7, 2014, 12:07 a.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116645/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 12:07 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Use QIODevice canReadLine and readLine instead of our own implementation.
> 
> 
> Diffs
> -----
> 
>   kded/backends/lan/socketlinereader.cpp 4cd8ef0 
> 
> Diff: https://git.reviewboard.kde.org/r/116645/diff/
> 
> 
> Testing
> -------
> 
> Unittest pass, ping and mpris seem to be responsive and work with no problem.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140307/98e3a4cb/attachment.html>