Review Request 116647: Some cleaning in lanlinkprovider.cpp

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116647/#review52331
-----------------------------------------------------------

Ship it!


It would be better to have esthetic changes (like adding 'm' in the name of private fields) and code execution flow changes (like adding the while loop) in separate reviews/commits, but it's okay.

- Albert Vaca Cintora


On March 7, 2014, 2:12 a.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116647/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 2:12 a.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> While learning this code I have been doing some small cleaning, mostly:
> -Return early in some cases
> -add m to member variables
> -spaces after coma (foo, bar, x)
> -Fix in how to handle hasPendingConnections (it might be more than one, so we have to do while)
> -Fix memory leak on connectionError
> -Some renames in variables that were hard to understand for a newbie (like me), mostly np to receivedPackage, id to deviceID
> -Keep an instance of QUdpSocket instead of instancing one every time we want to send datagrams
> 
> 
> Diffs
> -----
> 
>   kded/backends/lan/lanlinkprovider.h 85938b2 
>   kded/backends/lan/lanlinkprovider.cpp a205e1f 
> 
> Diff: https://git.reviewboard.kde.org/r/116647/diff/
> 
> 
> Testing
> -------
> 
> Connected both ways, device to pc, and pc to device.
> Ping works
> MPRIS works
> Sending image and video, works.
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140307/4607b041/attachment-0001.html>