<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116647/">https://git.reviewboard.kde.org/r/116647/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It would be better to have esthetic changes (like adding 'm' in the name of private fields) and code execution flow changes (like adding the while loop) in separate reviews/commits, but it's okay.</pre>
<br />
<p>- Albert Vaca Cintora</p>
<br />
<p>On March 7th, 2014, 2:12 a.m. CET, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdeconnect.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated March 7, 2014, 2:12 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeconnect-kde
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While learning this code I have been doing some small cleaning, mostly:
-Return early in some cases
-add m to member variables
-spaces after coma (foo, bar, x)
-Fix in how to handle hasPendingConnections (it might be more than one, so we have to do while)
-Fix memory leak on connectionError
-Some renames in variables that were hard to understand for a newbie (like me), mostly np to receivedPackage, id to deviceID
-Keep an instance of QUdpSocket instead of instancing one every time we want to send datagrams</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Connected both ways, device to pc, and pc to device.
Ping works
MPRIS works
Sending image and video, works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kded/backends/lan/lanlinkprovider.h <span style="color: grey">(85938b2)</span></li>
<li>kded/backends/lan/lanlinkprovider.cpp <span style="color: grey">(a205e1f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116647/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>