Review Request 116575: Never block the kded

[Àlex Fiestas]

> On March 4, 2014, 8:37 a.m., Yuri Samoilenko wrote:
> > restart function can't work correct in current logic. To implement pure async logic event queue needs to implement.
> > 
> >

True, yet it is more important to stop blocking the kded than having the restart method working imho. Will fix it asap anyway.


- Àlex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116575/#review51856
-----------------------------------------------------------


On March 3, 2014, 7:01 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116575/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 7:01 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> Never block the kded even if things go wrong.
> 
> In order to do this we need to switch to a completely asynchronous way of doing things, meaning that instead of returning bool on start/stop we have to emit signals.
> 
> 
> Diffs
> -----
> 
>   kded/kded.cpp 21465ec 
>   kded/kded.h 5914d96 
> 
> Diff: https://git.reviewboard.kde.org/r/116575/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140305/f8001bbb/attachment.html>