Review Request 118774: Figure out Messages.sh after code refactoring

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jun 16 10:15:35 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118774/
-----------------------------------------------------------

(Updated June 16, 2014, 10:15 a.m.)


Review request for kdeconnect, Albert Astals Cid and Albert Vaca Cintora.


Changes
-------

Created a separate kdeconnect-plugins catalog as suggested by Vaca.

Tested the execution using Astals's blog post, the output I get is:
./core
No filename specified at /home/kde-devel/src/kde-dev-scripts/extractrc line 122.
xgettext: error while opening "/home/kde-devel/src/kdeconnect-kde/po/kdeconnect-core.pot" for reading: No such file or directory
Bash exit code: 1
./kded
No filename specified at /home/kde-devel/src/kde-dev-scripts/extractrc line 122.
xargs: repack-pot.pl: No such file or directory

It looks bad, but I'm unsure why.


Repository: kdeconnect-kde


Description
-------

kded is translated again
Rename the core's pot to kdeconnect-core.pot and make sure the library loads the catalog when it's linked to.

Ideally we would have a Message.sh per plugin I guess, but I'm unsure this makes sense at the moment.


Diffs (updated)
-----

  core/Messages.sh 2a61de2 
  core/daemon.cpp 4243ea9 
  kded/Messages.sh PRE-CREATION 
  plugins/Messages.sh PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/118774/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140616/063d70cf/attachment.html>


More information about the KDEConnect mailing list