Review Request 118774: Figure out Messages.sh after code refactoring
Albert Astals Cid
aacid at kde.org
Sun Jun 15 22:49:41 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118774/#review60149
-----------------------------------------------------------
core/Messages.sh
<https://git.reviewboard.kde.org/r/118774/#comment41904>
Have you run this script? Doens't seem to me this assignment is correct, no? http://tsdgeos.blogspot.com/2010/08/how-to-run-messagessh-file-to-create.html
- Albert Astals Cid
On June 15, 2014, 10:41 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118774/
> -----------------------------------------------------------
>
> (Updated June 15, 2014, 10:41 p.m.)
>
>
> Review request for kdeconnect, Albert Astals Cid and Albert Vaca Cintora.
>
>
> Repository: kdeconnect-kde
>
>
> Description
> -------
>
> kded is translated again
> Rename the core's pot to kdeconnect-core.pot and make sure the library loads the catalog when it's linked to.
>
> Ideally we would have a Message.sh per plugin I guess, but I'm unsure this makes sense at the moment.
>
>
> Diffs
> -----
>
> core/Messages.sh 2a61de2
> core/daemon.cpp 4243ea9
> kded/Messages.sh PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/118774/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20140615/903282fd/attachment.html>
More information about the KDEConnect
mailing list