Review Request 121742: (GCI) Added RemoteControlClient to MprisPlugin

[Da-Jin Chu]

> On Dec. 31, 2014, 5:51 a.m., Albert Vaca Cintora wrote:
> > src/org/kde/kdeconnect/Plugins/MprisPlugin/RemoteControlClientManager.java, line 85
> > <https://git.reviewboard.kde.org/r/121742/diff/1/?file=336994#file336994line85>
> >
> >     unregister is not used. Should it be called when !isPlaying? Then make sure you remove the remoteControlClient=null, because we don't want that.

Well, I'm not sure when to pause and when to stop. It would make sense for the music to pause when clicking a headphone button, and also for the music to resume when clicking again, so it shouldn't be unregistered when no longer playing, but then in what scenario should we decide that the user is done with music?


- Da-Jin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121742/#review72735
-----------------------------------------------------------


On Dec. 29, 2014, 7 p.m., Da-Jin Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121742/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2014, 7 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Task: https://www.google-melange.com/gci/task/view/google/gci2014/5841649192140800
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 6cbe4a7 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java 22181ac 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MusicControlReceiver.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/NotificationPanel.java 4d5fa5a 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/NotificationReturnSlot.java 244eb55 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/RemoteControlClientManager.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121742/diff/
> 
> 
> Testing
> -------
> 
> Does not request AudioFocus, so the controls aren't available on lockscreen.
> Proof that it works:
> 
> 1. Plug in headphones that have play/pause button and click it.
> 2. Get https://play.google.com/store/apps/details?id=com.blackcrowsteam.musicstop&hl=en, play music from KDE-Connect, open "Music Stop" app, which will be able to stop the music.
> 
> 
> Thanks,
> 
> Da-Jin Chu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20141231/0ac2bd79/attachment.html>