Review Request 121742: (GCI) Added RemoteControlClient to MprisPlugin

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121742/#review72735
-----------------------------------------------------------



src/org/kde/kdeconnect/Plugins/MprisPlugin/MusicControlReceiver.java
<https://git.reviewboard.kde.org/r/121742/#comment50710>

    You could handle Stop as well. And for Pause and Stop you could send the command "Pause" instead of "PlayPause" and it should work. "Play" does not always work and that's why we avoid it, but "Pause" is okay.



src/org/kde/kdeconnect/Plugins/MprisPlugin/RemoteControlClientManager.java
<https://git.reviewboard.kde.org/r/121742/#comment50712>

    unregister is not used. Should it be called when !isPlaying? Then make sure you remove the remoteControlClient=null, because we don't want that.


- Albert Vaca Cintora


On des. 29, 2014, 8 p.m., Da-Jin Chu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121742/
> -----------------------------------------------------------
> 
> (Updated des. 29, 2014, 8 p.m.)
> 
> 
> Review request for kdeconnect.
> 
> 
> Repository: kdeconnect-android
> 
> 
> Description
> -------
> 
> Task: https://www.google-melange.com/gci/task/view/google/gci2014/5841649192140800
> 
> 
> Diffs
> -----
> 
>   AndroidManifest.xml 6cbe4a7 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java 22181ac 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/MusicControlReceiver.java PRE-CREATION 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/NotificationPanel.java 4d5fa5a 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/NotificationReturnSlot.java 244eb55 
>   src/org/kde/kdeconnect/Plugins/MprisPlugin/RemoteControlClientManager.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121742/diff/
> 
> 
> Testing
> -------
> 
> Does not request AudioFocus, so the controls aren't available on lockscreen.
> Proof that it works:
> 
> 1. Plug in headphones that have play/pause button and click it.
> 2. Get https://play.google.com/store/apps/details?id=com.blackcrowsteam.musicstop&hl=en, play music from KDE-Connect, open "Music Stop" app, which will be able to stop the music.
> 
> 
> Thanks,
> 
> Da-Jin Chu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20141231/19014fb1/attachment.html>