Review Request 121692: Implement a plugin for the inhibition of the screensaver when a device is connected

[Pramod Dematagoda]

> On Dec. 28, 2014, 11:42 p.m., Aleix Pol Gonzalez wrote:
> > I like the idea. Maybe it would make sense to have it as an opt-in option?
> > 
> > Also have you thought of all use-cases? What happens if you close the laptop lid? Will it inhibit then as well?

It does make sense as an opt in plugin, it wouldn't be the best surprise for the user to connect their device and then wonder why the screensaver does not come up.

It doesn't inhibit the action that occurs when the lid is closed, or any other actions like suspending or powering off. From my testing it is only the screensaver when the user is idle that is inhibited.


- Pramod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121692/#review72639
-----------------------------------------------------------


On Dec. 29, 2014, 12:42 a.m., Pramod Dematagoda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121692/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2014, 12:42 a.m.)
> 
> 
> Review request for kdeconnect and Albert Vaca Cintora.
> 
> 
> Repository: kdeconnect-kde
> 
> 
> Description
> -------
> 
> This plugin serves to inhibit the screensaver when enabled for a given device and that device is connected to kdeconnect. The inhibition is lifted when the plugin is either disabled or the device disconnects from kdeconnect.
> 
> 
> Diffs
> -----
> 
>   plugins/screensaver-inhibit/screensaverinhibitplugin.cpp PRE-CREATION 
>   plugins/CMakeLists.txt de1131d 
>   plugins/screensaver-inhibit/CMakeLists.txt PRE-CREATION 
>   plugins/screensaver-inhibit/README PRE-CREATION 
>   plugins/screensaver-inhibit/kdeconnect_screensaver_inhibit.desktop PRE-CREATION 
>   plugins/screensaver-inhibit/screensaverinhibitplugin.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121692/diff/
> 
> 
> Testing
> -------
> 
> Simple testing where a phone with kdeconnect is connected to a laptop with the proposed patch and it is observed that the screensaver does not start with the phone connected and the plugin enabled. The screensaver does start with the plugin either disabled or when the phone is disconnected.
> 
> 
> Thanks,
> 
> Pramod Dematagoda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdeconnect/attachments/20141229/4d3ab9c8/attachment.html>